From 99cf9d6201902e0cf34981b7ee3501b5f5163a8f Mon Sep 17 00:00:00 2001
From: Eric Wong <e@80x24.org>
Date: Sun, 20 Apr 2014 19:31:23 +0000
Subject: feed: close string ref before returning

Just in case there is an error, this should be more explicit.
---
 lib/PublicInbox/Feed.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'lib')

diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index 81ac66b9..54feaf5b 100644
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -327,8 +327,8 @@ sub do_cat_mail {
 				die "failed to setup string handle: $!\n";
 		binmode $fh;
 		my $bytes = $git->cat_blob($sha1, $fh);
-		return if $bytes <= 0;
 		close $fh or die "failed to close string handle: $!\n";
+		return if $bytes <= 0;
 	} else {
 		$str = `git cat-file blob $sha1`;
 		return if $? != 0 || length($str) == 0;
-- 
cgit v1.2.3-24-ge0c7