From 44c1e25436c5a4cc7b11a159aac05cfc60c37c17 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 23 Jan 2021 10:27:54 +0000 Subject: lei forget-external: don't show redundant "not found" Pathname/URL canonicalization may not change the result at all, so there's no point in trying (and failing) the same form twice if pre and post-canonicalization are identical. --- lib/PublicInbox/LeiExternal.pm | 2 ++ 1 file changed, 2 insertions(+) (limited to 'lib') diff --git a/lib/PublicInbox/LeiExternal.pm b/lib/PublicInbox/LeiExternal.pm index 5b5f08d1..e7693e09 100644 --- a/lib/PublicInbox/LeiExternal.pm +++ b/lib/PublicInbox/LeiExternal.pm @@ -69,9 +69,11 @@ sub lei_forget_external { my ($self, @locations) = @_; my $cfg = $self->_lei_cfg(1); my $quiet = $self->{opt}->{quiet}; + my %seen; for my $loc (@locations) { my (@unset, @not_found); for my $l ($loc, _canonicalize($loc)) { + next if $seen{$l}++; my $key = "external.$l.boost"; delete($cfg->{$key}); $self->_config('--unset', $key); -- cgit v1.2.3-24-ge0c7