From 3360a4deaef499211fa7dee368d07f0b26e49458 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 7 Jan 2017 01:44:44 +0000 Subject: qspawn: prepare to support runtime reloading of Limiter We may allow the {max} value of a limiter to be changed in the future, so lets start accounting for it before we spawn followup processes. --- lib/PublicInbox/Qspawn.pm | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'lib') diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm index 697c55a1..4950da25 100644 --- a/lib/PublicInbox/Qspawn.pm +++ b/lib/PublicInbox/Qspawn.pm @@ -31,14 +31,19 @@ sub _do_spawn { sub finish ($) { my ($self) = @_; my $limiter = $self->{limiter}; + my $running; if (delete $self->{rpipe}) { my $pid = delete $self->{pid}; $self->{err} = $pid == waitpid($pid, 0) ? $? : "PID:$pid still running?"; - $limiter->{running}--; + $running = --$limiter->{running}; } - if (my $next = shift @{$limiter->{run_queue}}) { - _do_spawn(@$next); + + # limiter->{max} may change dynamically + if (($running || $limiter->{running}) < $limiter->{max}) { + if (my $next = shift @{$limiter->{run_queue}}) { + _do_spawn(@$next); + } } $self->{err}; } -- cgit v1.2.3-24-ge0c7