From da87331b60ec182e939081eb16effa2b9aa8be3c Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 13 Nov 2023 13:15:42 +0000 Subject: spawn: don't append to scalarrefs on stdout/stderr None of our current code relies on it, and I can't imagine it's something we'd need in the future, actually... This keeps the door open for relying more on Spawn in TestCommon. --- lib/PublicInbox/Spawn.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/PublicInbox') diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm index 849438bc..9c680690 100644 --- a/lib/PublicInbox/Spawn.pm +++ b/lib/PublicInbox/Spawn.pm @@ -401,7 +401,7 @@ sub read_out_err ($) { seek($fh, 0, SEEK_SET); my $dst = $opt->{$fd}; $dst = $opt->{$fd} = $dst->[1] if ref($dst) eq 'ARRAY'; - PublicInbox::IO::read_all $fh, 0, $dst, length($$dst); + PublicInbox::IO::read_all $fh, 0, $dst } } -- cgit v1.2.3-24-ge0c7