From d28167f0a78a2010a752bdc16b3b8a62e8fc91ae Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 28 Nov 2022 05:32:01 +0000 Subject: fetch: eliminate File::Temp->filename var File::Temp objects are overloaded to automatically call ->filename when stringified, so there's no need to store the ->filename result on the Perl stack. --- lib/PublicInbox/Fetch.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'lib/PublicInbox') diff --git a/lib/PublicInbox/Fetch.pm b/lib/PublicInbox/Fetch.pm index d75e427b..198e2a60 100644 --- a/lib/PublicInbox/Fetch.pm +++ b/lib/PublicInbox/Fetch.pm @@ -48,7 +48,6 @@ sub do_manifest ($$$) { my $muri = URI->new("$ibx_uri/manifest.js.gz"); my $ft = File::Temp->new(TEMPLATE => 'm-XXXX', UNLINK => 1, DIR => $dir, SUFFIX => '.tmp'); - my $fn = $ft->filename; my $mf = "$dir/manifest.js.gz"; my $m0; # current manifest.js.gz contents if (open my $fh, '<', $mf) { @@ -57,7 +56,7 @@ sub do_manifest ($$$) { }; warn($@) if $@; } - my ($bn) = ($fn =~ m!/([^/]+)\z!); + my ($bn) = ($ft->filename =~ m!/([^/]+)\z!); my $curl_cmd = $lei->{curl}->for_uri($lei, $muri, qw(-R -o), $bn); my $opt = { -C => $dir }; $opt->{$_} = $lei->{$_} for (0..2); @@ -68,7 +67,7 @@ sub do_manifest ($$$) { return; } my $m1 = eval { - PublicInbox::LeiMirror::decode_manifest($ft, $fn, $muri); + PublicInbox::LeiMirror::decode_manifest($ft, $ft, $muri); } or return [ 404, $muri ]; my $mdiff = { %$m1 }; -- cgit v1.2.3-24-ge0c7