From c952a7208d9941495a9efbe83d0e4af866f05a64 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 5 Jul 2016 22:39:54 +0000 Subject: hval: get rid of unused parameter for new_msgid Exposing compressed Message-IDs in URLs was a mistake, remove a remnant of it. --- lib/PublicInbox/ExtMsg.pm | 2 +- lib/PublicInbox/Hval.pm | 2 +- lib/PublicInbox/View.pm | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'lib/PublicInbox') diff --git a/lib/PublicInbox/ExtMsg.pm b/lib/PublicInbox/ExtMsg.pm index 73bd4b17..62381e9e 100644 --- a/lib/PublicInbox/ExtMsg.pm +++ b/lib/PublicInbox/ExtMsg.pm @@ -99,7 +99,7 @@ again: } my $code = 404; - my $h = PublicInbox::Hval->new_msgid($mid, 1); + my $h = PublicInbox::Hval->new_msgid($mid); my $href = $h->as_href; my $html = $h->as_html; my $title = "Message-ID <$html> not found"; diff --git a/lib/PublicInbox/Hval.pm b/lib/PublicInbox/Hval.pm index 9ba78097..652aef3d 100644 --- a/lib/PublicInbox/Hval.pm +++ b/lib/PublicInbox/Hval.pm @@ -31,7 +31,7 @@ sub new { } sub new_msgid { - my ($class, $msgid, $no_compress) = @_; + my ($class, $msgid) = @_; $msgid = mid_clean($msgid); $class->new($msgid, $msgid); } diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index e8395ae9..dc6096f1 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -551,7 +551,7 @@ sub _parent_headers { my $irt = in_reply_to($hdr); if (defined $irt) { - my $v = PublicInbox::Hval->new_msgid($irt, 1); + my $v = PublicInbox::Hval->new_msgid($irt); my $html = $v->as_html; my $href = $v->as_href; $rv .= "In-Reply-To: <"; @@ -661,7 +661,7 @@ sub html_footer { } sub linkify_ref_nosrch { - my $v = PublicInbox::Hval->new_msgid($_[0], 1); + my $v = PublicInbox::Hval->new_msgid($_[0]); my $html = $v->as_html; my $href = $v->as_href; "<$html>"; -- cgit v1.2.3-24-ge0c7