From b46de4da83d797281af9603f350e5b7105845eed Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 1 Nov 2021 19:06:08 +0000 Subject: idx_stack: avoid conditional hash assignment weirdness I've been seeing the following error on occasion during "make check-run": $PWD/t/data-gen/reindex-time-range.v1-master index failed: Modification of a read-only value attempted at $DIR/lib/PublicInbox/SearchIdx.pm line 899, <$r> line 1. Perhaps this fixes it. In any case, a construct of: $h->{k} //= do { $h->{x} = ...; $val }; seems wrong and may cause Perl to error out depending on how hashes are randomized. --- lib/PublicInbox/IdxStack.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/PublicInbox') diff --git a/lib/PublicInbox/IdxStack.pm b/lib/PublicInbox/IdxStack.pm index d5123006..54d480bd 100644 --- a/lib/PublicInbox/IdxStack.pm +++ b/lib/PublicInbox/IdxStack.pm @@ -20,12 +20,12 @@ sub new { sub push_rec { my ($self, $file_char, $at, $ct, $blob_oid, $cmt_oid) = @_; my $rec = pack(PACK_FMT, $file_char, $at, $ct, $blob_oid, $cmt_oid); - $self->{unpack_fmt} //= do { + $self->{unpack_fmt} // do { my $len = length($cmt_oid); my $fmt = PACK_FMT; $fmt =~ s/H\*/H$len/g; $self->{rec_size} = length($rec); - $fmt; + $self->{unpack_fmt} = $fmt; }; print { $self->{wr} } $rec or die "print: $!"; $self->{tot_size} += length($rec); -- cgit v1.2.3-24-ge0c7