From 57024ca2ae548a103dae12efaaf2f852d2c47e0e Mon Sep 17 00:00:00 2001
From: Eric Wong <e@80x24.org>
Date: Sat, 26 Nov 2016 08:34:34 +0000
Subject: githttpbackend: error checking for input handling

This was sloppy code, all calls need to be checked
for failure.
---
 lib/PublicInbox/GitHTTPBackend.pm | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

(limited to 'lib/PublicInbox')

diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index d4914795..322005b5 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -273,6 +273,10 @@ sub serve_smart {
 sub input_to_file {
 	my ($env) = @_;
 	my $in = IO::File->new_tmpfile;
+	unless (defined $in) {
+		err($env, "could not open temporary file: $!");
+		return;
+	}
 	my $input = $env->{'psgi.input'};
 	my $buf;
 	while (1) {
@@ -281,11 +285,22 @@ sub input_to_file {
 			err($env, "error reading input: $!");
 			return;
 		}
-		last if ($r == 0);
-		$in->write($buf);
+		my $off = 0;
+		while ($r > 0) {
+			my $w = syswrite($in, $buf, $r, $off);
+			if (defined $w) {
+				$r -= $w;
+				$off += $w;
+			} else {
+				err($env, "error writing temporary file: $!");
+				return;
+			}
+		}
+	}
+	unless (defined(sysseek($in, 0, SEEK_SET))) {
+		err($env, "error seeking temporary file: $!");
+		return;
 	}
-	$in->flush;
-	$in->sysseek(0, SEEK_SET);
 	return $in;
 }
 
-- 
cgit v1.2.3-24-ge0c7