From 43d4030a3dfea1643ea2606b7186331e3b1e2ce7 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 13 Nov 2023 13:15:35 +0000 Subject: tmpfile: check `stat' errors, use autodie for unlink `stat' can fail due to bugs on our end or ENOMEM, but there's no autodie support for it. So just die if `unlink' fails, since the FS wouldn't be usable for tmpfiles in that state, anyways. --- lib/PublicInbox/Tmpfile.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'lib/PublicInbox') diff --git a/lib/PublicInbox/Tmpfile.pm b/lib/PublicInbox/Tmpfile.pm index 3040dd77..72dd9d24 100644 --- a/lib/PublicInbox/Tmpfile.pm +++ b/lib/PublicInbox/Tmpfile.pm @@ -1,9 +1,9 @@ -# Copyright (C) 2019-2021 all contributors +# Copyright (C) all contributors # License: AGPL-3.0+ package PublicInbox::Tmpfile; -use strict; -use v5.10.1; +use v5.12; use parent qw(Exporter); +use autodie qw(unlink); our @EXPORT = qw(tmpfile); use Fcntl qw(:DEFAULT); use Errno qw(EEXIST); @@ -21,7 +21,7 @@ sub tmpfile ($;$$) { if (defined $sock) { # add the socket inode number so we can figure out which # socket it belongs to - my @st = stat($sock); + my @st = stat($sock) or die "stat($sock): $!"; $id .= '-ino:'.$st[1]; } $id =~ tr!/!^!; @@ -31,7 +31,7 @@ sub tmpfile ($;$$) { do { my $fn = File::Spec->tmpdir . "/$id-".time.'-'.rand; if (sysopen(my $fh, $fn, $fl, 0600)) { # likely - unlink($fn) or warn "unlink($fn): $!"; # FS broken + unlink($fn); return $fh; # success } } while ($! == EEXIST); -- cgit v1.2.3-24-ge0c7