From 04320a20df07cd4f1ea344f3aa3ee6e15128a356 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 7 Dec 2020 07:40:51 +0000 Subject: extsearchidx: remove needless SHA-1 check There is no need to verify checksums of data already stored in git. Doing this ourselves also limits flexibility in moving to other hashes. --- lib/PublicInbox/ExtSearchIdx.pm | 12 ------------ 1 file changed, 12 deletions(-) (limited to 'lib/PublicInbox') diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm index 4de47b58..819c7903 100644 --- a/lib/PublicInbox/ExtSearchIdx.pm +++ b/lib/PublicInbox/ExtSearchIdx.pm @@ -91,14 +91,6 @@ sub attach_config { $cfg->each_inbox(\&_ibx_attach, $self); } -sub git_blob_digest ($) { - my ($bref) = @_; - my $dig = Digest::SHA->new(1); # XXX SHA256 later - $dig->add('blob '.length($$bref)."\0"); - $dig->add($$bref); - $dig; -} - sub is_bad_blob ($$$$) { my ($oid, $type, $size, $expect_oid) = @_; if ($type ne 'blob') { @@ -245,10 +237,6 @@ sub cur_ibx_xnum ($$) { my ($req, $bref) = @_; my $ibx = $req->{ibx} or die 'BUG: current {ibx} missing'; - # XXX overkill? - git_blob_digest($bref)->hexdigest eq $req->{oid} or die - "BUG: blob mismatch $req->{oid}"; - $req->{eml} = PublicInbox::Eml->new($bref); $req->{chash} = content_hash($req->{eml}); $req->{mids} = mids($req->{eml}); -- cgit v1.2.3-24-ge0c7