From 293c51d2c23ceb8b8018cf4bfa3deaf56f7753b2 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 24 Feb 2019 02:55:40 +0000 Subject: viewvcs: match 8000-byte lookup for git No need to scan the entire string, but prefer to match git behavior. This might be faster if/when Perl can create substrings efficiently using CoW. Fix a 80-column violation while we're at it. --- lib/PublicInbox/ViewVCS.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'lib/PublicInbox/ViewVCS.pm') diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm index b41adc44..962dc66b 100644 --- a/lib/PublicInbox/ViewVCS.pm +++ b/lib/PublicInbox/ViewVCS.pm @@ -135,14 +135,14 @@ sub solve_result { return html_page($ctx, 500, \$log); } - my $binary = index($$blob, "\0") >= 0; + my $bin = index(substr($$blob, 0, $BIN_DETECT), "\0") >= 0; if (defined $fn) { my $h = [ 'Content-Length', $size, 'Content-Type' ]; - push(@$h, ($binary ? 'application/octet-stream' : 'text/plain')); + push(@$h, ($bin ? 'application/octet-stream' : 'text/plain')); return delete($ctx->{-wcb})->([200, $h, [ $$blob ]]); } - if ($binary) { + if ($bin) { $log = "
$oid $type $size bytes (binary)" .
 			" $raw_link
" . $log; return html_page($ctx, 200, \$log); -- cgit v1.2.3-24-ge0c7