From c0805dfcd9a7b077c6ac4fa2cec31af60d50133e Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 5 Dec 2015 02:08:01 +0000 Subject: *view: avoid leading zero in time display of the hour Avoid the visual noise entirely by using a space instead. I sometimes have difficulty distinguishing '0' from '8' while other users may mistake it for an 'O' character. Most digital clocks I've seen will omit displaying a leading zero for the hour, too. This may also save transfer time by allowing better compression (since there is a space between the date and time anyways) and perhaps reduce client rendering time on some displays. We'll leave the leading zero for minutes since that seems pretty standard for digital clocks. --- lib/PublicInbox/View.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'lib/PublicInbox/View.pm') diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index f34e1f36..2506c954 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -712,9 +712,11 @@ sub missing_thread { sub _msg_date { my ($mime) = @_; my $ts = $mime->header('X-PI-TS') || msg_timestamp($mime); - POSIX::strftime('%Y-%m-%d %H:%M', gmtime($ts)); + fmt_ts($ts); } +sub fmt_ts { POSIX::strftime('%Y-%m-%d %k:%M', gmtime($_[0])) } + sub _inline_header { my ($dst, $state, $upfx, $mime, $level) = @_; my $pfx = INDENT x ($level - 1); @@ -865,7 +867,7 @@ sub dump_topics { $dst .= "$nl$pfx$dot$subj\n"; my $attr; - $ts = POSIX::strftime('%Y-%m-%d %H:%M', gmtime($ts)); + $ts = fmt_ts($ts); if ($n == 1) { $attr = "@ $ts UTC"; $n = ""; -- cgit v1.2.3-24-ge0c7