From b07c77aa98b39fcbaee7316021e341c868416a09 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 26 Dec 2015 01:11:15 +0000 Subject: view: reduce main landing page weight Hopefully, "mbox.gz" is sufficiently understandabe that we can get rid of the "title" attribute in tags (we already omitted the title in other pages). Additionally, drop the '@' in front of the date. The date should be obvious and is not necessary for headers without author attribution. --- lib/PublicInbox/View.pm | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) (limited to 'lib/PublicInbox/View.pm') diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 7603c514..ad90eb3d 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -15,7 +15,6 @@ use PublicInbox::Hval; use PublicInbox::MID qw/mid_clean id_compress mid2path/; use Digest::SHA qw/sha1_hex/; my $SALT = rand; -my $MBOX_TITLE = 'title="download thread as gzipped mbox"'; require POSIX; # TODO: make these constants tunable @@ -205,7 +204,7 @@ sub emit_thread_html { $next .= $final_anchor == 1 ? 'only message in' : 'end of'; $next .= " thread, back to index"; $next .= "\ndownload thread: "; - $next .= "mbox.gz"; + $next .= "mbox.gz"; $next .= " / follow: Atom feed"; $cb->write('
' . $next . "\n\n".
 			$foot .  '
'); @@ -879,19 +878,15 @@ sub dump_topics { my $attr; $ts = fmt_ts($ts); - if ($n == 1) { - $attr = "@ $ts UTC"; - $n = ""; - } else { - # $n isn't the total number of posts on the topic, - # just the number of posts in the current results - # window, so leave it unlabeled - $attr = "@ $ts UTC"; - $n = " ($n)"; - } + $attr = " $ts UTC"; + + # $n isn't the total number of posts on the topic, + # just the number of posts in the current results + # window, so leave it unlabeled + $n = $n == 1 ? '' : " ($n+ messages)"; + if ($level == 0 || $attr ne $prev_attr) { - my $mbox = qq(mbox.gz); + my $mbox = qq(mbox.gz); my $atom = qq(Atom); $pfx .= INDENT if $level > 0; $dst .= $pfx . $attr . $n . " - $mbox / $atom\n"; -- cgit v1.2.3-24-ge0c7