From b04e5cf1bc8969cca74ef764f2de960b1ea821a4 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 21 Jun 2016 02:39:27 +0000 Subject: spawn: improve error checking for fork failures fork failures are unfortunately common when Xapian has gigabytes and gigabytes mmapped. --- lib/PublicInbox/SpawnPP.pm | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'lib/PublicInbox/SpawnPP.pm') diff --git a/lib/PublicInbox/SpawnPP.pm b/lib/PublicInbox/SpawnPP.pm index 36223e81..179aba5e 100644 --- a/lib/PublicInbox/SpawnPP.pm +++ b/lib/PublicInbox/SpawnPP.pm @@ -12,7 +12,12 @@ sub public_inbox_fork_exec ($$$$$$) { my $set = POSIX::SigSet->new(); $set->fillset or die "fillset failed: $!"; sigprocmask(SIG_SETMASK, $set, $old) or die "can't block signals: $!"; + my $syserr; my $pid = fork; + unless (defined $pid) { # compat with Inline::C version + $syserr = $!; + $pid = -1; + } if ($pid == 0) { if ($in != 0) { dup2($in, 0) or die "dup2 failed for stdin: $!"; @@ -34,6 +39,7 @@ sub public_inbox_fork_exec ($$$$$$) { } } sigprocmask(SIG_SETMASK, $old) or die "can't unblock signals: $!"; + $! = $syserr; $pid; } -- cgit v1.2.3-24-ge0c7