From 9f5a583694396f84056b9d92255bba0197b52bc8 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 10 Jan 2020 09:14:19 +0000 Subject: spawn (and thus popen_rd) die on failure Most spawn and popen_rd callers die on failure to spawn, anyways, and some are missing checks entirely. This saves us a bunch of verbose error-checking code in callers. This also makes popen_rd more consistent, since it already dies on pipe creation failures. --- lib/PublicInbox/Spamcheck/Spamc.pm | 1 - 1 file changed, 1 deletion(-) (limited to 'lib/PublicInbox/Spamcheck/Spamc.pm') diff --git a/lib/PublicInbox/Spamcheck/Spamc.pm b/lib/PublicInbox/Spamcheck/Spamc.pm index bb288b16..d9cc47e3 100644 --- a/lib/PublicInbox/Spamcheck/Spamc.pm +++ b/lib/PublicInbox/Spamcheck/Spamc.pm @@ -23,7 +23,6 @@ sub spamcheck { my $rdr = { 0 => _msg_to_fh($self, $msg) }; my ($fh, $pid) = popen_rd($self->{checkcmd}, undef, $rdr); - defined $pid or die "failed to popen_rd spamc: $!\n"; my $r; unless (ref $out) { my $buf = ''; -- cgit v1.2.3-24-ge0c7