From 0c586dc64b3b6642a894e125d09df446667a4079 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 18 Apr 2020 03:38:53 +0000 Subject: reduce scope of mbox From_ line removal It's unnecessary overhead for anything which does Email::MIME parsing. It was never done for v2 indexing, even though v1->v2 conversions did NOT remove those From_ lines. There was never a need to remote From_ lines the v1 SearchIdx paths, either. Hitting a /$INBOX_URL/$MSGID/T/ endpoint with an 18 message thread reveals a ~0.5% speed improvement. This will become more apparent when we have a faster MIME parser. --- lib/PublicInbox/SearchIdx.pm | 2 -- 1 file changed, 2 deletions(-) (limited to 'lib/PublicInbox/SearchIdx.pm') diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm index d1290dc2..579b85e3 100644 --- a/lib/PublicInbox/SearchIdx.pm +++ b/lib/PublicInbox/SearchIdx.pm @@ -553,8 +553,6 @@ sub do_cat_mail { my ($git, $blob, $sizeref) = @_; my $str = $git->cat_file($blob, $sizeref) or die "BUG: $blob not found in $git->{git_dir}"; - # fixup bugs from import: - $$str =~ s/\A[\r\n]*From [^\r\n]*\r?\n//s; PublicInbox::MIME->new($str); } -- cgit v1.2.3-24-ge0c7