From 9c93edcdefb01f193aced818142b050aeffc04e1 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 20 Aug 2015 08:54:32 +0000 Subject: avoid using header_raw for Message-ID retrieval This is for consistency with ssoma. I doubt it makes a difference in practice, but in case somebody decides any of the Message-ID-containing headers should have strange characters, we'll decode and attempt to thread them. This isn't an attack vector, just a way to make messages thread improperly which is pointless... --- lib/PublicInbox/Search.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'lib/PublicInbox/Search.pm') diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm index d9e5fd1f..2c66e557 100644 --- a/lib/PublicInbox/Search.pm +++ b/lib/PublicInbox/Search.pm @@ -84,7 +84,7 @@ sub add_message { my $db = $self->{xdb}; my $doc_id; - my $mid_orig = mid_clean($mime->header_obj->header_raw('Message-ID')); + my $mid_orig = mid_clean($mime->header_obj->header('Message-ID')); my $mid = mid_compressed($mid_orig); my $was_ghost = 0; my $ct_msg = $mime->header('Content-Type') || 'text/plain'; @@ -348,9 +348,9 @@ sub link_message_to_parents { my $doc = $smsg->{doc}; my $mid = mid_compressed($smsg->mid); my $mime = $smsg->mime; - my $refs = $mime->header_obj->header_raw('References'); + my $refs = $mime->header_obj->header('References'); my @refs = $refs ? ($refs =~ /<([^>]+)>/g) : (); - my $irt = $mime->header_obj->header_raw('In-Reply-To'); + my $irt = $mime->header_obj->header('In-Reply-To'); if ($irt) { if ($irt =~ /<([^>]+)>/) { $irt = $1; @@ -529,7 +529,7 @@ sub index_blob { sub unindex_blob { my ($self, $git, $blob) = @_; my $mime = do_cat_mail($git, $blob) or return; - my $mid = $mime->header_obj->header_raw('Message-ID'); + my $mid = $mime->header_obj->header('Message-ID'); eval { $self->remove_message($mid) } if defined $mid; warn "W: unindex_blob $blob: $@\n" if $@; } -- cgit v1.2.3-24-ge0c7