From 3ac9f1f873bf7d7b9075cf492733a3d79b32e22a Mon Sep 17 00:00:00 2001
From: Eric Wong <e@80x24.org>
Date: Mon, 22 Aug 2022 02:33:43 +0000
Subject: qspawn: add type comments in a few places

This makes things easier-to-follow in a minimally-typed language.
---
 lib/PublicInbox/Qspawn.pm | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

(limited to 'lib/PublicInbox/Qspawn.pm')

diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index 53d0ad55..79db9e76 100644
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -132,7 +132,7 @@ sub start ($$$) {
 
 sub psgi_qx_init_cb {
 	my ($self) = @_;
-	my $async = delete $self->{async};
+	my $async = delete $self->{async}; # PublicInbox::HTTPD::Async
 	my ($r, $buf);
 	my $qx_fh = $self->{qx_fh};
 reread:
@@ -227,11 +227,10 @@ sub psgi_return_init_cb {
 		PublicInbox::GzipFilter::qsp_maybe($r->[1], $env);
 
 	my $wcb = delete $env->{'qspawn.wcb'};
-	my $async = delete $self->{async};
+	my $async = delete $self->{async}; # PublicInbox::HTTPD::Async
 	if (scalar(@$r) == 3) { # error
-		if ($async) {
-			# calls rpipe->close && ->event_step
-			$async->close;
+		if ($async) { # calls rpipe->close && ->event_step
+			$async->close; # PublicInbox::HTTPD::Async::close
 		} else {
 			$self->{rpipe}->close;
 			event_step($self);
@@ -255,9 +254,9 @@ sub psgi_return_init_cb {
 
 sub psgi_return_start { # may run later, much later...
 	my ($self) = @_;
-	if (my $async = $self->{psgi_env}->{'pi-httpd.async'}) {
+	if (my $cb = $self->{psgi_env}->{'pi-httpd.async'}) {
 		# PublicInbox::HTTPD::Async->new(rpipe, $cb, $cb_arg, $end_obj)
-		$self->{async} = $async->($self->{rpipe},
+		$self->{async} = $cb->($self->{rpipe},
 					\&psgi_return_init_cb, $self, $self);
 	} else { # generic PSGI
 		psgi_return_init_cb($self) while $self->{parse_hdr};
-- 
cgit v1.2.3-24-ge0c7