From 77fe488ce5432a49ea8499605e0d8e155834575f Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 10 Jun 2020 07:04:51 +0000 Subject: over: get_art: use dbh->prepare_cached This speeds up xt/imapd-validate.t by around 10% when used with an abandoned patch to remove ->query_xover. We may also depend on this further if we abandon storing doc_data in Xapian to save disk space. --- lib/PublicInbox/Over.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'lib/PublicInbox/Over.pm') diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm index 402cbf7c..1faeff41 100644 --- a/lib/PublicInbox/Over.pm +++ b/lib/PublicInbox/Over.pm @@ -179,11 +179,12 @@ SELECT COUNT(num) FROM over WHERE num > 0 sub get_art { my ($self, $num) = @_; my $dbh = $self->connect; - my $smsg = $dbh->selectrow_hashref(<<'', undef, $num); + my $sth = $dbh->prepare_cached(<<'', undef, 1); SELECT num,ds,ts,ddd FROM over WHERE num = ? LIMIT 1 - return load_from_row($smsg) if $smsg; - undef; + $sth->execute($num); + my $smsg = $sth->fetchrow_hashref; + $smsg ? load_from_row($smsg) : undef; } sub next_by_mid { -- cgit v1.2.3-24-ge0c7