From 39b7af9565f85a720e7eeb7564cfa661000cb7e9 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 3 Apr 2021 02:24:23 +0000 Subject: lei q: ensure wq workers shutdown on IMAP auth failures Leaving workers running on after auth failures is bad and messy, cleanup our process management to have consistent worker teardowns. Improve error reporting, too, instead of letting Mail::IMAPClient->exists fail due to undef. --- lib/PublicInbox/NetReader.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/PublicInbox/NetReader.pm') diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm index 6a52b479..c269d841 100644 --- a/lib/PublicInbox/NetReader.pm +++ b/lib/PublicInbox/NetReader.pm @@ -267,7 +267,7 @@ sub imap_common_init ($;$) { $mics->{$sec} //= mic_for($self, "$sec/", $mic_args, $lei); next unless $self->isa('PublicInbox::NetWriter'); my $dst = $uri->mailbox // next; - my $mic = $mics->{$sec}; + my $mic = $mics->{$sec} // die "Unable to continue\n"; next if $mic->exists($dst); # already exists $mic->create($dst) or die "CREATE $dst failed <$uri>: $@"; } -- cgit v1.2.3-24-ge0c7