From 59a7f5c908dc0e898e8925bcd06c5e526f86d063 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 21 Dec 2019 08:00:03 +0000 Subject: nntp: cmd_xrover: use named sub for long_response Introduce xrover_i which does the same thing as the anonymous sub it replaces. --- lib/PublicInbox/NNTP.pm | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) (limited to 'lib/PublicInbox/NNTP.pm') diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm index 9e0c1df0..95ac7d5f 100644 --- a/lib/PublicInbox/NNTP.pm +++ b/lib/PublicInbox/NNTP.pm @@ -803,6 +803,13 @@ sub hdr_mid_response ($$$$$$) { undef; } +sub xrover_i { + my ($self, $beg, $end) = @_; + my $h = over_header_for($self->{ng}->over, $$beg, 'references'); + more($self, "$$beg $h") if defined($h); + $$beg++ < $end; +} + sub cmd_xrover ($;$) { my ($self, $range) = @_; my $ng = $self->{ng} or return '412 no newsgroup selected'; @@ -812,16 +819,8 @@ sub cmd_xrover ($;$) { $range = $self->{article} unless defined $range; my $r = get_range($self, $range); return $r unless ref $r; - my ($beg, $end) = @$r; - my $mm = $ng->mm; - my $over = $ng->over; more($self, '224 Overview information follows'); - - long_response($self, sub { - my $h = over_header_for($over, $$beg, 'references'); - more($self, "$$beg $h") if defined($h); - $$beg++ < $end; - }); + long_response($self, \&xrover_i, @$r); } sub over_line ($$$$) { -- cgit v1.2.3-24-ge0c7