From 171a9c24022ad7efef9248fc51fc357eed6aeb8a Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 31 Dec 2020 19:20:59 -1400 Subject: lei_store: quiet down "git var" failures $git->qx and $git->popen now $env and $opt for redirects like lower-level popen_rd. This may be beneficial in other places. --- lib/PublicInbox/LeiStore.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'lib/PublicInbox/LeiStore.pm') diff --git a/lib/PublicInbox/LeiStore.pm b/lib/PublicInbox/LeiStore.pm index a23efed5..7c62ffea 100644 --- a/lib/PublicInbox/LeiStore.pm +++ b/lib/PublicInbox/LeiStore.pm @@ -54,7 +54,9 @@ sub git_epoch_max { sub git_ident ($) { my ($git) = @_; - chomp(my $i = $git->qx(qw(var GIT_COMMITTER_IDENT))); + open my $null, '>', '/dev/null' or die "open /dev/null: $!"; + my $opt = { 2 => $null }; + chomp(my $i = $git->qx(qw(var GIT_COMMITTER_IDENT), undef, $opt)); warn "$git->{git_dir} GIT_COMMITTER_IDENT failed\n" if $?; $i =~ /\A(.+) <([^>]+)> [0-9]+ [-\+]?[0-9]+$/ ? ($1, $2) : ('lei user', 'x@example.com') -- cgit v1.2.3-24-ge0c7