From d3a2b3c8df7ce2c2d62b532b814a3fdcc89f1cac Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 24 Jan 2021 04:46:50 -0700 Subject: lei q: disable remote externals if locals exist --remote should be explicitly enabled if local externals are present, since users may be offline or on expensive + metered Internet while traveling. In the future, --remote will probably default to caching/memoizing all messages it fetches to increase the usefulness of --local. --- lib/PublicInbox/LeiQuery.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'lib/PublicInbox/LeiQuery.pm') diff --git a/lib/PublicInbox/LeiQuery.pm b/lib/PublicInbox/LeiQuery.pm index a7938e8b..7713902b 100644 --- a/lib/PublicInbox/LeiQuery.pm +++ b/lib/PublicInbox/LeiQuery.pm @@ -24,7 +24,9 @@ sub lei_q { # --external is enabled by default, but allow --no-external if ($opt->{external} //= 1) { my $cb = $lxs->can('prepare_external'); - $self->_externals_each($cb, $lxs); + my $ne = $self->_externals_each($cb, $lxs); + $opt->{remote} //= $ne == $lxs->remotes; + delete($lxs->{remotes}) if !$opt->{remote}; } my $xj = $lxs->concurrency($opt); my $ovv = PublicInbox::LeiOverview->new($self) or return; -- cgit v1.2.3-24-ge0c7