From b40f4f1f81f79577e19e9926e14979625303eb59 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 30 Mar 2021 09:10:55 +0000 Subject: lei q: avoid redundant default setting for sort with l2m No point in munging user-supplied $lei->{opt} when %mset_opt exists. We'll be depending on docid being in descending order for saved search support. --- lib/PublicInbox/LeiOverview.pm | 2 -- 1 file changed, 2 deletions(-) (limited to 'lib/PublicInbox/LeiOverview.pm') diff --git a/lib/PublicInbox/LeiOverview.pm b/lib/PublicInbox/LeiOverview.pm index 68f6c792..cdd9ee04 100644 --- a/lib/PublicInbox/LeiOverview.pm +++ b/lib/PublicInbox/LeiOverview.pm @@ -101,8 +101,6 @@ sub new { if ($json) { $lei->{dedupe} //= PublicInbox::LeiDedupe->new($lei); } else { - # default to the cheapest sort since MUA usually resorts - $opt->{'sort'} //= 'docid' if $devfd < 0; $lei->{l2m} = eval { PublicInbox::LeiToMail->new($lei) }; return $lei->fail($@) if $@; if ($opt->{mua} && $lei->{l2m}->lock_free) { -- cgit v1.2.3-24-ge0c7