From 72ccceeb02542dda09b8a641c2bd17dd74440cc2 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 26 Sep 2023 07:44:40 +0000 Subject: spawn: add run_wait to simplify spawn+waitpid use It's basically the `system' perlop with support for env overrides, redirects, chdir, rlimits, and setpgid support. --- lib/PublicInbox/LeiMailDiff.pm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'lib/PublicInbox/LeiMailDiff.pm') diff --git a/lib/PublicInbox/LeiMailDiff.pm b/lib/PublicInbox/LeiMailDiff.pm index c813144f..5e2e4b0b 100644 --- a/lib/PublicInbox/LeiMailDiff.pm +++ b/lib/PublicInbox/LeiMailDiff.pm @@ -6,7 +6,7 @@ package PublicInbox::LeiMailDiff; use v5.12; use parent qw(PublicInbox::IPC PublicInbox::LeiInput PublicInbox::MailDiff); -use PublicInbox::Spawn qw(spawn which); +use PublicInbox::Spawn qw(run_wait); use File::Path (); require PublicInbox::LeiRediff; @@ -20,9 +20,7 @@ sub diff_a ($$) { push @$cmd, qw(-- a), "N$self->{nr}"; my $rdr = { -C => "$self->{tmp}" }; @$rdr{1, 2} = @$lei{1, 2}; - my $pid = spawn($cmd, $lei->{env}, $rdr); - waitpid($pid, 0); - $lei->child_error($?) if $?; # for git diff --exit-code + run_wait($cmd, $lei->{env}, $rdr) and $lei->child_error($?); File::Path::remove_tree($self->{curdir}); } -- cgit v1.2.3-24-ge0c7