From 19b791f4894efcb6e545a6b51c8147298363358f Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 17 Oct 2023 23:37:52 +0000 Subject: use read_all in more places to improve safety `readline' ops may not detect errors on partial reads. This saves us some code to reduce cognitive overhead for readers. We'll also support reusing a destination buffers so it can work more nicely with existing code. --- lib/PublicInbox/LeiConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/PublicInbox/LeiConfig.pm') diff --git a/lib/PublicInbox/LeiConfig.pm b/lib/PublicInbox/LeiConfig.pm index b3495487..c47708d8 100644 --- a/lib/PublicInbox/LeiConfig.pm +++ b/lib/PublicInbox/LeiConfig.pm @@ -28,7 +28,7 @@ sub cfg_edit_done { # PktOp lei->do_env cb $lei->cfg_dump($self->{-f}); } or do { seek($fh, 0, SEEK_SET); - return cfg_do_edit($self, do { local $/; <$fh> }); + return cfg_do_edit($self, read_all($fh)); }; $self->cfg_verify($cfg) if $self->can('cfg_verify'); } -- cgit v1.2.3-24-ge0c7