From 135f34ac52b4c6118753027c03cd8e88286aa037 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 22 Sep 2023 21:13:14 +0000 Subject: lei: improve ->fail internal API Allow the exit code to be the first argument intead of the last to match our ->child_error, as well as the BSD err(3) API. We'll also avoid shifting user-passed exit codes so $? can be passed as-is without losing signal information. --- lib/PublicInbox/LEI.pm | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) (limited to 'lib/PublicInbox/LEI.pm') diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index c61ce76d..368f9357 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -29,6 +29,7 @@ use File::Path (); use File::Spec; use Carp (); use Sys::Syslog qw(openlog syslog closelog); +use Scalar::Util qw(looks_like_number); our $quit = \&CORE::exit; our ($current_lei, $errors_log, $listener, $oldset, $dir_idle); my $GLP = Getopt::Long::Parser->new; @@ -518,13 +519,17 @@ sub sigpipe_handler { # handles SIGPIPE from @WQ_KEYS workers fail_handler($_[0], 13, delete $_[0]->{1}); } -sub fail ($$;$) { - my ($self, $msg, $exit_code) = @_; - local $current_lei = $self; - $self->{failed}++; - warn(substr($msg, -1, 1) eq "\n" ? $msg : "$msg\n") if defined $msg; - $self->{pkt_op_p}->pkt_do('fail_handler') if $self->{pkt_op_p}; - x_it($self, ($exit_code // 1) << 8); +sub fail ($;@) { + my ($lei, @msg) = @_; + my $exit_code = looks_like_number($msg[0]) ? shift(@msg) : undef; + local $current_lei = $lei; + $lei->{failed}++; + if (@msg) { + push @msg, "\n" if substr($msg[-1], -1, 1); + warn @msg; + } + $lei->{pkt_op_p}->pkt_do('fail_handler') if $lei->{pkt_op_p}; + x_it($lei, $exit_code // (1 << 8)); undef; } -- cgit v1.2.3-24-ge0c7