From 6ca8f8d03fa8ee93edc8299f53d624f5d5841408 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 30 May 2018 02:54:48 +0000 Subject: respect umask if core.sharedRepository is not set This is consistent with git itself and the previous behavior was a result of misunderstanding of how git interprets this. And adjust tests slightly to match the new behavior. Reported-by: Konstantin Ryabitsev <38873789-ab42-65a1-20c9-12c30b171f4f@linuxfoundation.org> --- lib/PublicInbox/InboxWritable.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/PublicInbox/InboxWritable.pm') diff --git a/lib/PublicInbox/InboxWritable.pm b/lib/PublicInbox/InboxWritable.pm index 5c11a36c..9b0cdfd0 100644 --- a/lib/PublicInbox/InboxWritable.pm +++ b/lib/PublicInbox/InboxWritable.pm @@ -175,7 +175,7 @@ sub _read_git_config_perm { sub _git_config_perm { my $self = shift; my $perm = scalar @_ ? $_[0] : _read_git_config_perm($self); - return PERM_GROUP if (!defined($perm) || $perm eq ''); + return PERM_UMASK if (!defined($perm) || $perm eq ''); return PERM_UMASK if ($perm eq 'umask'); return PERM_GROUP if ($perm eq 'group'); if ($perm =~ /\A(?:all|world|everybody)\z/) { -- cgit v1.2.3-24-ge0c7