From f06e84220e5566e74c4af675a7afaf1636b024e4 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 14 Jul 2020 02:14:32 +0000 Subject: over+msgmap: do not store filename after DBI->connect SQLite already knows the filename internally, so avoid having it as a long-lived Perl SV to save some bytes when there's many inboxes and open DBs. --- lib/PublicInbox/Inbox.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/PublicInbox/Inbox.pm') diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm index 3d9754dc..267be4e3 100644 --- a/lib/PublicInbox/Inbox.pm +++ b/lib/PublicInbox/Inbox.pm @@ -204,9 +204,9 @@ sub search ($;$) { sub over ($) { my ($self) = @_; my $srch = search($self, 1) or return; - $self->{over} ||= eval { + $self->{over} //= eval { my $over = $srch->{over_ro}; - $over->dbh_new; # may fail + $over->connect; # may fail $over; } } -- cgit v1.2.3-24-ge0c7