From 7f454bace0442cd5ce22068ec1e098e964d82778 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 7 Jul 2020 20:37:35 +0000 Subject: hval: to_filename: return `undef' instead of empty string Returning an empty string for a filename makes no sense, so instead return `undef' so the caller can setup a fallback using the "//" operator. This fixes uninitialized variable warnings because split() on an empty string returns `undef', which caused to_filename to warn on s// and tr// ops. --- lib/PublicInbox/Hval.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/PublicInbox/Hval.pm') diff --git a/lib/PublicInbox/Hval.pm b/lib/PublicInbox/Hval.pm index 46a83916..e21a64a6 100644 --- a/lib/PublicInbox/Hval.pm +++ b/lib/PublicInbox/Hval.pm @@ -94,12 +94,12 @@ sub obfuscate_addrs ($$;$) { # like format_sanitized_subject in git.git pretty.c with '%f' format string sub to_filename ($) { - my ($s, undef) = split(/\n/, $_[0]); + my $s = (split(/\n/, $_[0]))[0] // return; # empty string => undef $s =~ s/[^A-Za-z0-9_\.]+/-/g; $s =~ tr/././s; $s =~ s/[\.\-]+\z//; $s =~ s/\A[\.\-]+//; - $s + $s eq '' ? undef : $s; } # convert a filename (or any string) to HTML attribute -- cgit v1.2.3-24-ge0c7