From b04e5cf1bc8969cca74ef764f2de960b1ea821a4 Mon Sep 17 00:00:00 2001
From: Eric Wong <e@80x24.org>
Date: Tue, 21 Jun 2016 02:39:27 +0000
Subject: spawn: improve error checking for fork failures

fork failures are unfortunately common when Xapian has
gigabytes and gigabytes mmapped.
---
 lib/PublicInbox/Git.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

(limited to 'lib/PublicInbox/Git.pm')

diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index bc0e5064..f47bc439 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -28,7 +28,9 @@ sub _bidi_pipe {
 
 	my @cmd = ('git', "--git-dir=$self->{git_dir}", qw(cat-file), $batch);
 	my $redir = { 0 => fileno($out_r), 1 => fileno($in_w) };
-	$self->{$pid} = spawn(\@cmd, undef, $redir);
+	my $p = spawn(\@cmd, undef, $redir);
+	defined $p or fail($self, "spawn failed: $!");
+	$self->{$pid} = $p;
 	$out_w->autoflush(1);
 	$self->{$out} = $out_w;
 	$self->{$in} = $in_r;
@@ -122,6 +124,7 @@ sub popen {
 sub qx {
 	my ($self, @cmd) = @_;
 	my $fh = $self->popen(@cmd);
+	defined $fh or return;
 	local $/ = "\n";
 	return <$fh> if wantarray;
 	local $/;
-- 
cgit v1.2.3-24-ge0c7