From 9d1e5fadd7d18f4c96ab0509d673040e34225a04 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 14 Aug 2016 10:21:09 +0000 Subject: www: do not unecessarily escape some chars in paths Based on reading RFC 3986, it seems '@', ':', '!', '$', '&', "'", '; '(', ')', '*', '+', ',', ';', '=' are all allowed in path-absolute where we have the Message-ID. In any case, it seems '@' is fairly common in path components nowadays and too common in Message-IDs. --- lib/PublicInbox/Feed.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/PublicInbox/Feed.pm') diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm index 240c336f..232a91c0 100644 --- a/lib/PublicInbox/Feed.pm +++ b/lib/PublicInbox/Feed.pm @@ -137,7 +137,7 @@ sub emit_atom_thread { my $fh = $cb->([200, ['Content-Type' => 'application/atom+xml']]); my $ibx = $ctx->{-inbox}; my $html_url = $ibx->base_url($ctx->{env}); - $html_url .= PublicInbox::Hval->new_msgid($mid)->as_href; + $html_url .= PublicInbox::Hval->new_msgid($mid)->{href}; $feed_opts->{url} = $html_url; $feed_opts->{emit_header} = 1; @@ -269,7 +269,7 @@ sub feed_entry { my $mid = $header_obj->header_raw('Message-ID'); defined $mid or return; $mid = PublicInbox::Hval->new_msgid($mid); - my $href = $midurl . $mid->as_href . '/'; + my $href = $midurl . $mid->{href}. '/'; my $date = $header_obj->header('Date'); my $updated = feed_updated($date); -- cgit v1.2.3-24-ge0c7