From 7e782e8ff3ec64500913069a2efb5815fe711a36 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 1 Jun 2020 10:06:52 +0000 Subject: www: remove smsg_mime API and adjust callers To further simplify callers and avoid embarrasing memory explosions[1], we can finally eliminate this method in favor of smsg_eml. [1] commit 7d02b9e64455831d3bda20cd2e64e0c15dc07df5 ("view: stop storing all MIME objects on large threads") fixed a huge memory blowup. --- lib/PublicInbox/Feed.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'lib/PublicInbox/Feed.pm') diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm index b770a350..4c1056b4 100644 --- a/lib/PublicInbox/Feed.pm +++ b/lib/PublicInbox/Feed.pm @@ -53,9 +53,9 @@ sub new_html_i { my ($nr, $ctx) = @_; my $msgs = $ctx->{msgs}; while (my $smsg = shift @$msgs) { - my $m = $ctx->{-inbox}->smsg_mime($smsg) or next; - my $more = scalar @$msgs; - return PublicInbox::View::index_entry($m, $ctx, $more); + my $eml = $ctx->{-inbox}->smsg_eml($smsg) or next; + return PublicInbox::View::eml_entry($ctx, $smsg, $eml, + scalar @$msgs); } PublicInbox::View::pagination_footer($ctx, './new.html'); } -- cgit v1.2.3-24-ge0c7