From 58852a50f6a72265cce1e4729aae3875bba5aa96 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 23 Apr 2020 01:54:52 +0000 Subject: feed: drop needless version check We don't need to be checking inbox versions in parts of the WWW code. Checking the presence of $ibx->over is enough, everywhere. --- lib/PublicInbox/Feed.pm | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) (limited to 'lib/PublicInbox/Feed.pm') diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm index 07347c63..4cb295e6 100644 --- a/lib/PublicInbox/Feed.pm +++ b/lib/PublicInbox/Feed.pm @@ -84,15 +84,10 @@ sub recent_msgs { my ($ctx) = @_; my $ibx = $ctx->{-inbox}; my $max = $ibx->{feedmax}; - my $qp = $ctx->{qp}; - my $v = $ibx->version; - if ($v > 2) { - die "BUG: unsupported inbox version: $v\n"; - } - if ($ibx->over) { - return PublicInbox::View::paginate_recent($ctx, $max); - } + return PublicInbox::View::paginate_recent($ctx, $max) if $ibx->over; + # only for rare v1 inboxes which aren't indexed at all + my $qp = $ctx->{qp}; my $hex = '[a-f0-9]'; my $addmsg = qr!^:000000 100644 \S+ (\S+) A\t${hex}{2}/${hex}{38}$!; my $delmsg = qr!^:100644 000000 (\S+) \S+ D\t(${hex}{2}/${hex}{38})$!; -- cgit v1.2.3-24-ge0c7