From 3da6c88f4bdffd2ae83d0c9108e20136c8986a80 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 26 Apr 2014 22:22:35 +0000 Subject: feed: comment about the %deleted hash It's strictly not necessary anymore since commit fa6168c56bdd1cece178b6b852a9b2cba6ce6ffb ("feed: message must exist in current HEAD to show up") However it can still save us some unnecessary syscalls and round-trips to the "git cat-file --batch" process, so it's probably worth th cost of stuffing it in a hash. --- lib/PublicInbox/Feed.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/PublicInbox/Feed.pm') diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm index 3b2b7af9..a8578e76 100644 --- a/lib/PublicInbox/Feed.pm +++ b/lib/PublicInbox/Feed.pm @@ -156,7 +156,7 @@ sub each_recent_blob { my $pid = open(my $log, '-|', @cmd) or die('open `'.join(' ', @cmd) . " pipe failed: $!\n"); - my %deleted; + my %deleted; # only an optimization at this point my $last; my $nr = 0; my @commits = (); -- cgit v1.2.3-24-ge0c7