From 7a85c3cd6c7c0257a04343ca345cf0f23d71729c Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 25 Jul 2021 12:44:23 +0000 Subject: extindex: support --jobs/-j properly on creation for shard count This wasn't wired up properly, but Xapian appears to suffer from I/O amplification problems as DB shards get larger: https://lists.xapian.org/pipermail/xapian-discuss/2019-February/009727.html <23640.32170.703368.841021@y.dockes.com> Of course, we shouldn't have too many shards, either; because performance problems with too many shards was the entire reason extindex was created: https://lists.xapian.org/pipermail/xapian-discuss/2020-August/009823.html <20200826064728.GA32239@dcvr> --- lib/PublicInbox/ExtSearchIdx.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'lib/PublicInbox/ExtSearchIdx.pm') diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm index fb1f511e..22edbb4b 100644 --- a/lib/PublicInbox/ExtSearchIdx.pm +++ b/lib/PublicInbox/ExtSearchIdx.pm @@ -52,7 +52,8 @@ sub new { parallel => 1, lock_path => "$dir/ei.lock", }, __PACKAGE__; - $self->{shards} = $self->count_shards || nproc_shards($opt->{creat}); + $self->{shards} = $self->count_shards || + nproc_shards({ nproc => $opt->{jobs} }); my $oidx = PublicInbox::OverIdx->new("$self->{xpfx}/over.sqlite3"); $self->{-no_fsync} = $oidx->{-no_fsync} = 1 if !$opt->{fsync}; $self->{oidx} = $oidx; -- cgit v1.2.3-24-ge0c7