From f6c9b3da9cf87cfbde7b95772de6b337ba46ef68 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 24 Jun 2019 02:52:11 +0000 Subject: ds: remove support for DS->write(undef) We call ->flush_write directly, now; so we can eliminate a needless check. --- lib/PublicInbox/DS.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'lib/PublicInbox/DS.pm') diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm index 8fc49eee..ba8bd95f 100644 --- a/lib/PublicInbox/DS.pm +++ b/lib/PublicInbox/DS.pm @@ -518,14 +518,13 @@ sub flush_write ($) { =head2 C<< $obj->write( $data ) >> Write the specified data to the underlying handle. I may be scalar, -scalar ref, code ref (to run when there), or undef just to kick-start. +scalar ref, code ref (to run when there). Returns 1 if writes all went through, or 0 if there are writes in queue. If it returns 1, caller should stop waiting for 'writable' events) =cut sub write { my ($self, $data) = @_; - return flush_write($self) unless defined $data; # nobody should be writing to closed sockets, but caller code can # do two writes within an event, have the first fail and -- cgit v1.2.3-24-ge0c7