From b7c0114745e5b11f5606c43c391b2417779cbdf3 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 11 Jan 2020 22:34:59 +0000 Subject: cgit: drop cgit_parse_hdr wrapper Unlike PublicInbox::GitHTTPBackend::git_parse_hdr, cgit_parse_hdr does nothing interesting besides calling parse_cgi_headers. So just make a reference to PublicInbox::GitHTTPBackend::parse_cgi_headers and call it. --- lib/PublicInbox/Cgit.pm | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) (limited to 'lib/PublicInbox/Cgit.pm') diff --git a/lib/PublicInbox/Cgit.pm b/lib/PublicInbox/Cgit.pm index c42f8847..d9b7831f 100644 --- a/lib/PublicInbox/Cgit.pm +++ b/lib/PublicInbox/Cgit.pm @@ -11,7 +11,6 @@ use PublicInbox::GitHTTPBackend; use PublicInbox::Git; # not bothering with Exporter for a one-off *input_prepare = *PublicInbox::GitHTTPBackend::input_prepare; -*parse_cgi_headers = *PublicInbox::GitHTTPBackend::parse_cgi_headers; *serve = *PublicInbox::GitHTTPBackend::serve; use warnings; use PublicInbox::Qspawn; @@ -94,11 +93,7 @@ my @PASS_ENV = qw( ); # XXX: cgit filters may care about more variables... -sub cgit_parse_hdr { # {parse_hdr} for Qspawn - my ($r, $bref) = @_; - my $res = parse_cgi_headers($r, $bref) or return; # incomplete - $res; -} +my $parse_cgi_headers = \&PublicInbox::GitHTTPBackend::parse_cgi_headers; sub call { my ($self, $env) = @_; @@ -127,7 +122,7 @@ sub call { my $rdr = input_prepare($env) or return r(500); my $qsp = PublicInbox::Qspawn->new($self->{cmd}, $cgi_env, $rdr); my $limiter = $self->{pi_config}->limiter('-cgit'); - $qsp->psgi_return($env, $limiter, \&cgit_parse_hdr); + $qsp->psgi_return($env, $limiter, $parse_cgi_headers); } 1; -- cgit v1.2.3-24-ge0c7