From 3d20f6e4c214747b3e700d30e4cac70a33a817d8 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 14 Dec 2019 05:22:18 +0000 Subject: address: explicitly reject local-only addresses Apparently, neither our previous address parsing code nor Email::Address::XS recognizes local, username-only addresses in the form of (without "@host"). Without this change, Email::Address::XS->address would return "undef", so we need to filter it out via "grep { defined }" It seems the cases where users email each other on the same machine is small and public-inbox won't be able to index addresses for those cases... Oh well :/ --- lib/PublicInbox/Address.pm | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'lib/PublicInbox/Address.pm') diff --git a/lib/PublicInbox/Address.pm b/lib/PublicInbox/Address.pm index 433b36eb..c23a5d62 100644 --- a/lib/PublicInbox/Address.pm +++ b/lib/PublicInbox/Address.pm @@ -4,12 +4,15 @@ package PublicInbox::Address; use strict; use warnings; -sub xs_emails { map { $_->address() } parse_email_addresses($_[0]) } +sub xs_emails { + grep { defined } map { $_->address() } parse_email_addresses($_[0]) +} sub xs_names { - map { + grep { defined } map { my $n = $_->name; - $n = $_->user if $n eq $_->address; + my $addr = $_->address; + $n = $_->user if defined($addr) && $n eq $addr; $n; } parse_email_addresses($_[0]); } -- cgit v1.2.3-24-ge0c7