From bbb8c7788ebaa7f3679d387725ee1998f0b2f615 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 8 Jan 2019 11:13:27 +0000 Subject: searchmsg: get rid of termlist scanning for mid It doesn't seem to be used anywhere --- lib/PublicInbox/SearchMsg.pm | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/lib/PublicInbox/SearchMsg.pm b/lib/PublicInbox/SearchMsg.pm index c7787ea1..5a2ca83b 100644 --- a/lib/PublicInbox/SearchMsg.pm +++ b/lib/PublicInbox/SearchMsg.pm @@ -157,29 +157,17 @@ sub references { defined $x ? $x : ''; } -sub _get_term_val ($$$) { - my ($self, $pfx, $re) = @_; - my $doc = $self->{doc}; - my $end = $doc->termlist_end; - my $i = $doc->termlist_begin; - $i->skip_to($pfx); - if ($i != $end) { - my $val = $i->get_termname; - $val =~ s/$re// and return $val; - } - undef; -} - sub mid ($;$) { my ($self, $mid) = @_; if (defined $mid) { $self->{mid} = $mid; - } elsif (my $rv = $self->{mid}) { + } elsif (defined(my $rv = $self->{mid})) { $rv; } elsif ($self->{doc}) { - $self->{mid} = _get_term_val($self, 'Q', qr/\AQ/); + die "SHOULD NOT HAPPEN\n"; } else { + die "NO {mime} for mid\n" unless $self->{mime}; $self->_extract_mid; # v1 w/o Xapian } } -- cgit v1.2.3-24-ge0c7