From a45aef4d6415553dd1f6744770b00ea9033f58d7 Mon Sep 17 00:00:00 2001 From: Kyle Meyer Date: Tue, 21 Apr 2020 21:33:59 -0400 Subject: view: actually omit subject text when dumping topics Despite dump_topics() calling dedupe_subject() on the subject, the index shows partly duplicated subjects, for example ` [PATCH 2/2] t/www_listing: avoid 'once' warnings ` [PATCH v2] t/www_listing: avoid 'once' warnings " In the second line, the omission character " is appended, but the entire subject is shown. To display the subject with duplicated parts omitted, regenerate it from the array that is modified by dedupe_subject(). --- lib/PublicInbox/View.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 280d0ea5..5144a130 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -1096,6 +1096,7 @@ sub dump_topics { my @next_prev = @subj; # full copy my $omit = dedupe_subject($prev_subj, \@subj, ' "'); $prev_subj = \@next_prev; + $subj = join(' ', @subj); $subj = ascii_html($subj); obfuscate_addrs($obfs_ibx, $subj) if $obfs_ibx; $href = mid_href($mid); -- cgit v1.2.3-24-ge0c7