From 9406144c54215626e79ee65fc3c89ff350506317 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 16 Oct 2021 22:52:49 -1100 Subject: extindex: guard against false mismatch unrefs I'm not sure if this is a bug or not (or it could be an old bug in the v2 indexing code). --- lib/PublicInbox/ExtSearchIdx.pm | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm index daff656d..cb5256a2 100644 --- a/lib/PublicInbox/ExtSearchIdx.pm +++ b/lib/PublicInbox/ExtSearchIdx.pm @@ -921,6 +921,16 @@ ibx_id = ? AND xnum >= ? AND xnum <= ? my ($xnum, $hex) = unpack('JH*', $k); my $bin = pack('H*', $hex); my $exp = $mismatch{$xnum}; + if (defined $exp) { + my $smsg = $ibx->over->get_art($xnum) // next; + # $xnum may be expired by another process + if ($smsg->{blob} eq $hex) { + warn <<""; +BUG: (non-fatal) $ekey #$xnum $smsg->{blob} still matches (old exp: $exp) + + next; + } # else: continue to unref + } my $m = defined($exp) ? "mismatch (!= $exp)" : 'stale'; warn("# $xnum:$hex (#@$docids): $m\n"); for my $i (@$docids) { -- cgit v1.2.3-24-ge0c7