From 8e7ce7fb5220a74dc17c07e8dce931d53d1b2c24 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 19 Jan 2019 08:13:11 +0000 Subject: solver: note the synchronous nature of index preparation It's not likely to be worth our time to support a callback-driven model for something which happens once per patch series. --- lib/PublicInbox/SolverGit.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/SolverGit.pm b/lib/PublicInbox/SolverGit.pm index 51be2cdf..42bb6033 100644 --- a/lib/PublicInbox/SolverGit.pm +++ b/lib/PublicInbox/SolverGit.pm @@ -221,11 +221,13 @@ sub prepare_index ($$$$) { my ($r, $w); my $path_a = $di->{path_a} or die "BUG: path_a missing for $oid_full"; my $mode_a = $di->{mode_a} || extract_old_mode($di); - my @git = (qw(git -C), $wt_dir); + # unlike git-apply(1), this only gets called once in a patch + # series and happens too quickly to be worth making async: pipe($r, $w) or die "pipe: $!"; my $rdr = { 0 => fileno($r) }; - my $pid = spawn([@git, qw(update-index -z --index-info)], {}, $rdr); + my $pid = spawn([qw(git -C), $wt_dir, + qw(update-index -z --index-info)], undef, $rdr); close $r or die "close pipe(r): $!"; print $w "$mode_a $oid_full\t$path_a\0" or die "print update-index: $!"; -- cgit v1.2.3-24-ge0c7