From 77b96aee09b2711e645ea2b04ab912b5e3285c73 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 7 Dec 2020 07:40:53 +0000 Subject: shard_add_eidx_info: pass $eidx_key instead of $ibx object This improves consistency with sibling methods such as ->shard_remove_eidx_info and ->add_xref3. Passing the $eidx_key scalar is preferable to the entire $ibx object for IPC-friendliness. --- lib/PublicInbox/ExtSearchIdx.pm | 2 +- lib/PublicInbox/SearchIdxShard.pm | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm index c06b25a9..c82d1633 100644 --- a/lib/PublicInbox/ExtSearchIdx.pm +++ b/lib/PublicInbox/ExtSearchIdx.pm @@ -125,7 +125,7 @@ sub do_xpost ($$) { if (my $new_smsg = $req->{new_smsg}) { # 'm' on cross-posted message my $xnum = $req->{xnum}; $self->{oidx}->add_xref3($docid, $xnum, $oid, $eidx_key); - $idx->shard_add_eidx_info($docid, $xibx, $eml); + $idx->shard_add_eidx_info($docid, $eidx_key, $eml); check_batch_limit($req); } else { # 'd' my $rm_eidx_info; diff --git a/lib/PublicInbox/SearchIdxShard.pm b/lib/PublicInbox/SearchIdxShard.pm index 182bbde2..579ed196 100644 --- a/lib/PublicInbox/SearchIdxShard.pm +++ b/lib/PublicInbox/SearchIdxShard.pm @@ -144,8 +144,7 @@ sub index_raw { } sub shard_add_eidx_info { - my ($self, $docid, $xibx, $eml) = @_; - my $eidx_key = $xibx->eidx_key; + my ($self, $docid, $eidx_key, $eml) = @_; if (my $w = $self->{w}) { my $hdr = $eml->header_obj->as_string; my $len = length($hdr); -- cgit v1.2.3-24-ge0c7