From 5cec164a0c5688a0410964cdc07c7e843e175545 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 6 Oct 2021 09:42:18 +0000 Subject: xt/perf-msgview: modernize, support TEST_BLOB This helped me quickly reproduce a bug in Encode[1] and will help me determine performance implications of workarounds for the aforementioned bug. [1] https://rt.cpan.org/Public/Bug/Display.html?id=139622 --- xt/perf-msgview.t | 39 ++++++++++++++++++++++++++------------- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/xt/perf-msgview.t b/xt/perf-msgview.t index 59980839..f97c06fb 100644 --- a/xt/perf-msgview.t +++ b/xt/perf-msgview.t @@ -1,14 +1,16 @@ -# Copyright (C) 2019-2021 all contributors +#!perl -w +# Copyright (C) all contributors # License: AGPL-3.0+ use strict; -use warnings; -use Test::More; +use v5.10.1; +use PublicInbox::TestCommon; use Benchmark qw(:all); use PublicInbox::Inbox; use PublicInbox::View; -use PublicInbox::TestCommon; +use PublicInbox::Spawn qw(popen_rd); my $inboxdir = $ENV{GIANT_INBOX_DIR} // $ENV{GIANT_PI_DIR}; +my $blob = $ENV{TEST_BLOB}; plan skip_all => "GIANT_INBOX_DIR not defined for $0" unless $inboxdir; my @cat = qw(cat-file --buffer --batch-check --batch-all-objects); @@ -22,10 +24,13 @@ require_mods qw(Plack::Util); use_ok 'Plack::Util'; my $ibx = PublicInbox::Inbox->new({ inboxdir => $inboxdir, name => 'name' }); my $git = $ibx->git; -my $fh = $git->popen(@cat); -my $vec = ''; -vec($vec, fileno($fh), 1) = 1; -select($vec, undef, undef, 60) or die "timed out waiting for --batch-check"; +my $fh = $blob ? undef : $git->popen(@cat); +if ($fh) { + my $vec = ''; + vec($vec, fileno($fh), 1) = 1; + select($vec, undef, undef, 60) or + die "timed out waiting for --batch-check"; +} my $ctx = { env => { HTTP_HOST => 'example.com', 'psgi.url_scheme' => 'https' }, @@ -47,11 +52,19 @@ my $cb = sub { my $t = timeit(1, sub { $ctx->{obuf} = \$obuf; $ctx->{mhref} = '../'; - while (<$fh>) { - ($oid, $type) = split / /; - next if $type ne 'blob'; - ++$n; - $git->cat_async($oid, $cb); + if (defined $blob) { + my $nr = $ENV{NR} // 10000; + for (1..$nr) { + ++$n; + $git->cat_async($blob, $cb); + } + } else { + while (<$fh>) { + ($oid, $type) = split / /; + next if $type ne 'blob'; + ++$n; + $git->cat_async($oid, $cb); + } } $git->cat_async_wait; }); -- cgit v1.2.3-24-ge0c7