From 578520277aaf723b174a2567aff90c10e29abbcb Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 28 May 2021 00:07:54 +0000 Subject: lei_mail_sync: debug code for uncommitted txn I'm not 100% sure why, but "lei up" seems to cause uncommitted transaction errors. LeiToMail calls sto->set_sync_info, but LeiXSearch should call sto->done and lms_commit, so I'm not sure where the uncommited transaction is coming from... --- lib/PublicInbox/LeiMailSync.pm | 10 ++++++++++ lib/PublicInbox/LeiXSearch.pm | 3 +++ 2 files changed, 13 insertions(+) diff --git a/lib/PublicInbox/LeiMailSync.pm b/lib/PublicInbox/LeiMailSync.pm index d9c30580..6120d59f 100644 --- a/lib/PublicInbox/LeiMailSync.pm +++ b/lib/PublicInbox/LeiMailSync.pm @@ -356,4 +356,14 @@ sub forget_folder { $dbh->do('DELETE FROM folders WHERE fid = ?', undef, $fid); } +# FIXME: something with "lei " is causing uncommitted transaction +# warnings, not sure what... +sub DESTROY { + my ($self) = @_; + my $dbh = $self->{dbh} or return; + return if $dbh->{ReadOnly}; + use Carp; + warn "BUG $$ $0 $self {dbh} UNCOMMITTED ", Carp::longmess(); +} + 1; diff --git a/lib/PublicInbox/LeiXSearch.pm b/lib/PublicInbox/LeiXSearch.pm index 3482082d..e2a8e8e3 100644 --- a/lib/PublicInbox/LeiXSearch.pm +++ b/lib/PublicInbox/LeiXSearch.pm @@ -357,6 +357,9 @@ sub query_done { # EOF callback for main daemon if (my $lxs = delete $lei->{lxs}) { $lxs->wq_wait_old(\&xsearch_done_wait, $lei); } + if ($lei->{opt}->{'mail-sync'} && !$lei->{sto}) { + warn "BUG: {sto} missing with --mail-sync"; + } my $wait = $lei->{sto} ? $lei->{sto}->ipc_do('done') : undef; $lei->{ovv}->ovv_end($lei); my $start_mua; -- cgit v1.2.3-24-ge0c7