From 208450d2347ab92de7dcb9733fb51543df32635a Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 5 Jul 2020 23:27:51 +0000 Subject: view: /$INBOX/$MSGID/t/: avoid extra hash lookup in eml case We can build and buffer the HTML section once the first non-ghost message in a thread is loaded, so there's no need to perform an extra check on $ctx->{nr} once the $eml is ready. --- lib/PublicInbox/View.pm | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 65695392..138e0c3a 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -389,15 +389,7 @@ sub next_in_queue ($$) { sub stream_thread_i { # PublicInbox::WwwStream::getline callback my ($ctx, $eml) = @_; - - if ($eml) { - if ($ctx->{nr} == 1) { - $ctx->{-title_html} = - ascii_html($ctx->{smsg}->{subject}); - $ctx->zmore($ctx->html_top); - } - goto &thread_eml_entry; # tail recursion - } + goto &thread_eml_entry if $eml; # tail recursion return unless exists($ctx->{skel}); my $ghost_ok = $ctx->{nr}++; while (1) { @@ -405,6 +397,11 @@ sub stream_thread_i { # PublicInbox::WwwStream::getline callback if ($smsg) { if (exists $smsg->{blob}) { # next message for cat-file $ctx->{level} = $lvl; + if (!$ghost_ok) { # first non-ghost + $ctx->{-title_html} = + ascii_html($smsg->{subject}); + $ctx->zmore($ctx->html_top); + } return $smsg; } # buffer the ghost entry and loop -- cgit v1.2.3-24-ge0c7