From 11fcb0446a6749ce2ac582d7a1f361ec7355d2f8 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 16 May 2020 07:35:02 +0000 Subject: view: drop a newline before first attachment link However, we'll always have a newline before subsequent attachments links after the first. For the initial part of a multipart message, this regression appeared in 1.5.0, but the display was overly clumped in prior relases, too. Fixes: 453dee4881a9c764 ("msg_iter: pass $idx as a scalar, not array") --- lib/PublicInbox/View.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index ef5f4b3a..7264f4b6 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -483,7 +483,7 @@ sub multipart_text_as_html { sub attach_link ($$$$;$) { my ($ctx, $ct, $p, $fn, $err) = @_; my ($part, $depth, $idx) = @$p; - my $nl = substr($idx, -2) eq '.1' ? '' : "\n"; # like join("\n", ...) + my $nl = $idx eq '1' ? '' : "\n"; # like join("\n", ...) my $size = bytes::length($part->body); # hide attributes normally, unless we want to aid users in -- cgit v1.2.3-24-ge0c7