about summary refs log tree commit homepage
path: root/lib/PublicInbox/Feed.pm
DateCommit message (Collapse)
2014-05-04add various TODO items
Screen space is precious, and we do not need it in the abbreviated view.
2014-05-02view: API cleanup, remove "as_" prefix
These views are not OO, so the "as_" prefix makes little sense and "as_html" conflicts with Hval, which is OO.
2014-05-02reduce copies by passing string refs to Email::MIME
This should reduce data copies and memory usage, according to Email::Simple documentation.
2014-05-01workaround Mail::Thread memory leak
Thanks to Ask for the patch in https://rt.cpan.org/Public/Bug/Display.html?id=22817
2014-05-01purge Email::Address cache
This prevents memory bloat in case we're serving many requests with a large, diverse set of email addresses (potentially from malicious spammers).
2014-04-30feed: unset GIT_DIR and use "git --git-dir=.. log"
This should elimate all of our %ENV dependencies in the WWW portion of our code.
2014-04-29implement our own cat-file --batch wrapper
We use --git-dir=... instead of $ENV{GIT_DIR} because ENV changes do not propagate easily with mod_perl.
2014-04-28feed: call URI->as_string explicitly
Implicit string conversion is more confusing.
2014-04-28use relative URLs in HTML index
Browsers know how to follow relative URLs, so we may generate smaller HTML pages.
2014-04-28feed: swap order of "next" and "head" links
This is one less key stroke for somebody paging through the list history.
2014-04-28feed: avoid redirect on permalink
This saves one round-trip request response so reduces latency over slow links. The redirect only exists for convenience and isn't 100% reliable in case the Message-ID terminates with a .(html|txt) suffix.
2014-04-28feed: dead code elimination around dropped endpoints
public-inbox is for discussion, so top-level posts do not get special treatment.
2014-04-28feed: disable navigation to previous page
This is unfortunately needed for scalability to long histories. The design of git requires it to traverse full history to walk forward in time, since commits can only record past history. Instead, replace "prev" with a "head" link to zip us back to the most recent page. Users who wish to go backwards can use browser history, which should always work on our old-fashioned HTML pages.
2014-04-28feed: pedantically quote HTML attributes
This is more correct, although it costs us 4 bytes.
2014-04-28allow running as a Plack app without CGI emulation
This might be slightly cleaner, though generating the base URL now has an ugly condition in it.
2014-04-27feeds use XHTML to avoid tag soup
This should work in most browsers, lets find out!
2014-04-27Feed: <id> element must be a URI, oops :x
For each feed element, we'll just use the link since there's currently no suitable URN.
2014-04-26feed: comment about the %deleted hash
It's strictly not necessary anymore since commit fa6168c56bdd1cece178b6b852a9b2cba6ce6ffb ("feed: message must exist in current HEAD to show up") However it can still save us some unnecessary syscalls and round-trips to the "git cat-file --batch" process, so it's probably worth th cost of stuffing it in a hash.
2014-04-26feed: message must exist in current HEAD to show up
We do not want recently-deleted spam showing up when looking in old histories.
2014-04-26huge refactor of encoding handling
Hopefully this simplifies and corrects our usage of Perl encoding APIs.
2014-04-24html: refactor header value handling to be OO
This helps us keep track of escaping which needs to be done for various levels.
2014-04-22fix quoted URL generation in feeds
While we're at it, make sure strange characters are escaped properly in Message-IDs. We'll need tests for all this behavior.
2014-04-21feed: fix address when multiple addresses exist
This needs to be cleaned up
2014-04-21config: use description file for gitweb
Do not repeat ourselves, just use the same description file gitweb uses to avoid surprising users.
2014-04-21html/index: fix broken prev/next pagination on short histories
We do not have much history in public-inbox meta, so do not mislead users with strange navigation elements which lead nowhere.
2014-04-21feed: there is only one atom feed, with all messages
This is not a blog. All posts, whether replies or not, carry equal weight.
2014-04-21html/index: do not waste space with non-existent thread roots
Screen real-estate is valuable, and missing roots tend to be false-positive matches (using Subject, not In-Reply-To or References).
2014-04-20feed: close string ref before returning
Just in case there is an error, this should be more explicit.
2014-04-20cgi: delay some requires
This shaves off nearly 100ms when my Core2Duo is clocked to 800Mhz when rendering a full HTML index.
2014-04-20feed: speed up blob checks if Git.pm is usable
Git::cat_blob is a handy interface to read multiple emails without incurring fork + exec overhead. Git.pm is GPLv2+, not GPLv2-only, so we may link to it.
2014-04-19cgi: index pages allow iterating some pagination
This allows WWW readers to slowly page through the entire history of the mailing list.
2014-04-17cgi: sort HTML index by most recent date
This is hopefully the most user-friendly method.
2014-04-17HTML: various encoding fixups
2014-04-17Feed: add bug note on memory cycle
This affects users of long-lived processes (FastCGI/Plack)
2014-04-15cgi: support /all.html page with inline threads
Maybe this increases readability for now.
2014-04-15HTML: use shorter URLs in indices
Long URLs are not needed for HTML pages, but may be for feeds since they're often resyndicated and not consumed by the browser.
2014-04-15HTML: ensure hrefs are quoted properly
We may be breaking some parsers or allowing more breakage to slip through without quotes. We waste some bytes, though.
2014-04-14cgi: fix up top-level index
We do not have all messages in the top-level index (and we need to adjust the test while we're at it).
2014-04-11cgi: update feed/view and tests for shorter URLs
Code should be consistent with the design docs (and we will need better tests).
2014-04-11cgi: /$LISTNAME/ and /$LISTNAME/index.html are equal
This prevents ambiguity when switching URLs between static file servers and CGI. The /$LISTNAME/index.html URL appearing in the wild is inevitable because of our static file server support. Worst yet, there's no easy/consistent way to get all installations detect and 301 them to the shorter /$LISTNAME/. So we make the CGI support /$LISTNAME/index.html. The downside of this is the potential duplicate entry in all caches.
2014-04-09preliminary HTML index generation
Using JWZ threading might work decently for this. Haven't checked in lynx, yet.
2014-04-08feed: filter out each_recent_blob wrapper
We will need it for HTML indices, too.
2014-04-07feed: generate takes a hashref for args
Passing a giant argument list is to error prone and hard-to-document.
2014-04-06feed: reuse view class to display message
This reduces duplicated/similar code and hopefully makes things more consistent.
2014-04-05feed: remove unnecessary use
We no longer use DateTime::Format::Mail.
2014-04-05feed: use Date::Parse to parse dates
This is a smaller module dependency-wise and should be easier-to-install for folks with limited packaging systems or network/disk capacity. We do not need very powerful date parsing, as bad date formats are likely the work of spammers.
2014-04-05get a basic CGI feed sender running
We should be able to wire up the rest, soon.
2014-03-24initial cut at Atom feed generation
This should make it easier for non-ssoma users to follow.