Date | Commit message (Collapse) |
|
Screen space is precious, and we do not need it in the abbreviated
view.
|
|
These views are not OO, so the "as_" prefix makes little sense
and "as_html" conflicts with Hval, which is OO.
|
|
This should reduce data copies and memory usage, according
to Email::Simple documentation.
|
|
Thanks to Ask for the patch in
https://rt.cpan.org/Public/Bug/Display.html?id=22817
|
|
This prevents memory bloat in case we're serving many requests
with a large, diverse set of email addresses (potentially from
malicious spammers).
|
|
This should elimate all of our %ENV dependencies in the WWW portion
of our code.
|
|
We use --git-dir=... instead of $ENV{GIT_DIR} because ENV changes
do not propagate easily with mod_perl.
|
|
Implicit string conversion is more confusing.
|
|
Browsers know how to follow relative URLs, so we may generate
smaller HTML pages.
|
|
This is one less key stroke for somebody paging through the
list history.
|
|
This saves one round-trip request response so reduces latency over
slow links. The redirect only exists for convenience and isn't 100%
reliable in case the Message-ID terminates with a .(html|txt)
suffix.
|
|
public-inbox is for discussion, so top-level posts do not get
special treatment.
|
|
This is unfortunately needed for scalability to long histories.
The design of git requires it to traverse full history to walk
forward in time, since commits can only record past history.
Instead, replace "prev" with a "head" link to zip us back to
the most recent page. Users who wish to go backwards can use
browser history, which should always work on our old-fashioned
HTML pages.
|
|
This is more correct, although it costs us 4 bytes.
|
|
This might be slightly cleaner, though generating the base URL
now has an ugly condition in it.
|
|
This should work in most browsers, lets find out!
|
|
For each feed element, we'll just use the link since there's
currently no suitable URN.
|
|
It's strictly not necessary anymore since
commit fa6168c56bdd1cece178b6b852a9b2cba6ce6ffb
("feed: message must exist in current HEAD to show up")
However it can still save us some unnecessary syscalls and
round-trips to the "git cat-file --batch" process, so it's probably
worth th cost of stuffing it in a hash.
|
|
We do not want recently-deleted spam showing up when looking
in old histories.
|
|
Hopefully this simplifies and corrects our usage of Perl encoding
APIs.
|
|
This helps us keep track of escaping which needs to be done
for various levels.
|
|
While we're at it, make sure strange characters are escaped properly
in Message-IDs. We'll need tests for all this behavior.
|
|
This needs to be cleaned up
|
|
Do not repeat ourselves, just use the same description file
gitweb uses to avoid surprising users.
|
|
We do not have much history in public-inbox meta, so do
not mislead users with strange navigation elements which
lead nowhere.
|
|
This is not a blog. All posts, whether replies or not,
carry equal weight.
|
|
Screen real-estate is valuable, and missing roots tend to
be false-positive matches (using Subject, not In-Reply-To
or References).
|
|
Just in case there is an error, this should be more explicit.
|
|
This shaves off nearly 100ms when my Core2Duo is clocked to 800Mhz
when rendering a full HTML index.
|
|
Git::cat_blob is a handy interface to read multiple emails
without incurring fork + exec overhead. Git.pm is GPLv2+,
not GPLv2-only, so we may link to it.
|
|
This allows WWW readers to slowly page through the entire history
of the mailing list.
|
|
This is hopefully the most user-friendly method.
|
|
|
|
This affects users of long-lived processes (FastCGI/Plack)
|
|
Maybe this increases readability for now.
|
|
Long URLs are not needed for HTML pages, but may be for feeds since
they're often resyndicated and not consumed by the browser.
|
|
We may be breaking some parsers or allowing more breakage
to slip through without quotes. We waste some bytes, though.
|
|
We do not have all messages in the top-level index
(and we need to adjust the test while we're at it).
|
|
Code should be consistent with the design docs
(and we will need better tests).
|
|
This prevents ambiguity when switching URLs between static
file servers and CGI.
The /$LISTNAME/index.html URL appearing in the wild is inevitable
because of our static file server support. Worst yet, there's
no easy/consistent way to get all installations detect and 301
them to the shorter /$LISTNAME/. So we make the CGI support
/$LISTNAME/index.html.
The downside of this is the potential duplicate entry in all caches.
|
|
Using JWZ threading might work decently for this.
Haven't checked in lynx, yet.
|
|
We will need it for HTML indices, too.
|
|
Passing a giant argument list is to error prone and
hard-to-document.
|
|
This reduces duplicated/similar code and hopefully makes things more
consistent.
|
|
We no longer use DateTime::Format::Mail.
|
|
This is a smaller module dependency-wise and should be easier-to-install
for folks with limited packaging systems or network/disk capacity.
We do not need very powerful date parsing, as bad date formats are
likely the work of spammers.
|
|
We should be able to wire up the rest, soon.
|
|
This should make it easier for non-ssoma users to follow.
|