about summary refs log tree commit homepage
path: root/lib/PublicInbox/View.pm
diff options
context:
space:
mode:
Diffstat (limited to 'lib/PublicInbox/View.pm')
-rw-r--r--lib/PublicInbox/View.pm6
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 6f79f601..30572216 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -427,10 +427,10 @@ sub attach_link ($$$$) {
         } else {
                 $sfn = 'a.bin';
         }
-        my @ret = qq($nl<a\nhref="$upfx$idx-$sfn">[-- Attachment #$idx: );
+        my $ret = qq($nl<a\nhref="$upfx$idx-$sfn">[-- Attachment #$idx: );
         my $ts = "Type: $ct, Size: $size bytes";
-        push(@ret, ($desc eq '') ? "$ts --]" : "$desc --]\n[-- $ts --]");
-        join('', @ret, "</a>\n");
+        $ret .= ($desc eq '') ? "$ts --]" : "$desc --]\n[-- $ts --]";
+        $ret .= "</a>\n";
 }
 
 sub add_text_body {